Refactoring and improved error handling #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to accidentally skip some things user specified, better be strict. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
We have some examples of this already in tests; example-cfbs.json. Also refactored error checking for missing files / folders. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
There are more cases of GenericExitError which could be converted, but we can do those over time. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
To make it clear which exceptions are custom to CFBS. To avoid potential collisions or confusion with other libraries' exceptions. Also dropped "Generic" in GenericExitError - CFBSExitError seems descriptive enough. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
jakub-nt
reviewed
Jul 11, 2025
jakub-nt
reviewed
Jul 11, 2025
craigcomstock
requested changes
Jul 11, 2025
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
a few typos is all.
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
craigcomstock
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.