Skip to content

Better handled assertion and programmer errors #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olehermanse merged 1 commit into from
Jul 4, 2025
Merged

Better handled assertion and programmer errors #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cfbs/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import logging as log
import sys
import os
from typing import Union

from cfbs.result import Result
Expand Down Expand Up @@ -246,6 +247,10 @@ def main() -> int:

The only thing we want to do here is call _main() and handle exceptions (errors).
"""
if os.getenv("CFBACKTRACE") == "1":
r = _main()
assert type(r) is int
return r
try:
r = _main()
# TODO: I'm not exactly sure when the commands
Expand All @@ -256,5 +261,13 @@ def main() -> int:
print("Error: " + str(e))
except GenericExitError as e:
print("Error: " + str(e))
except (AssertionError, ProgrammerError) as e:
print("Error: " + str(e))
print(
"This is an unexpected error indicating a bug, please create a ticket at:"
)
print("https://northerntech.atlassian.net/")
print("(Rerun with CFBACKTRACE=1 in front of your command to show backtraces)")

# TODO: Handle other exceptions
return 1