Skip to content

Conversation

@olehermanse
Copy link
Member

No description provided.

@olehermanse olehermanse requested a review from larsewi July 2, 2025 15:34
@olehermanse olehermanse force-pushed the replace branch 4 times, most recently from 77c5962 to 11a36e2 Compare July 2, 2025 22:22
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the build step should be called only replace and made more generic? It could be useful for other things as well? Although I guess you could always use the sh build step in that case. 🤔

@olehermanse
Copy link
Member Author

Maybe the build step should be called only replace and made more generic? It could be useful for other things as well? Although I guess you could always use the sh build step in that case. 🤔

Yes, I'm already working on a generic version, however I think it's better to have replace_version as well, mainly because it will have the magic behavior of finding the current version, rather than having to specify what should be put in.

@olehermanse olehermanse merged commit 9388825 into cfengine:master Jul 3, 2025
11 checks passed
@olehermanse olehermanse deleted the replace branch July 3, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants