Fixed handling of role and agent fields in data#177
Merged
olehermanse merged 2 commits intocfengine:masterfrom Apr 3, 2026
Merged
Fixed handling of role and agent fields in data#177olehermanse merged 2 commits intocfengine:masterfrom
olehermanse merged 2 commits intocfengine:masterfrom
Conversation
craigcomstock
approved these changes
Apr 3, 2026
| systeminfo = ssh_cmd(connection, "systeminfo") | ||
| assert systeminfo is None or (type(systeminfo) is str and len(systeminfo) > 0) | ||
| # Note: ssh_cmd is supposed to return None on failure however, it seems | ||
| # like there are some cases where it returns output on failure |
Contributor
There was a problem hiding this comment.
specifically I think this is the case e.g. centos-7 which has a rather old version of the script command which we use in case no pty is present (the vagrant shell provisioning case). Agreed about "command not found" being not very robust... we could be more specific or try to find another way around no-pty case other than script command that works back info old distributions like centos-7.
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
craigcomstock
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.