Skip to content

Fixed cross-device link error by downloading to target directory #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsewi merged 2 commits into from
Nov 5, 2025
+1 −2
Merged

Fixed cross-device link error by downloading to target directory #157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1680f5e
Fixed cross-device link error by downloading to target directory
larsewi Nov 5, 2025
7d5d36f
Removed leftover print message from debugging
larsewi Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cf_remote/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ def has_downloaded_package(path, filename, checksum, insecure):


def download_package(url, path=None, checksum=None, insecure=False):
print(insecure)
assert path is None or type(path) is str and len(path) > 0

if checksum and not SHA256_RE.match(checksum):
Expand All @@ -85,7 +84,7 @@ def download_package(url, path=None, checksum=None, insecure=False):
return path

print("Downloading package: '{}'".format(path))
fd, tmp = tempfile.mkstemp()
fd, tmp = tempfile.mkstemp(dir=os.path.dirname(path))
answer = urllib.request.urlopen(url).read()
os.write(fd, answer)
os.close(fd)
Expand Down