Skip to content

In CI scripts, nodesource.com is often flaky, instead check if sufficient node version is already present #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
craigcomstock wants to merge 3 commits into from
Closed

In CI scripts, nodesource.com is often flaky, instead check if sufficient node version is already present #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eb8b25
Tidy up ci/setup.sh based on shellcheck linter
craigcomstock Nov 19, 2025
24ecb6e
In CI scripts, nodesource.com is often flaky, instead check if suffic…
craigcomstock Nov 19, 2025
ac4b655
test the change in buildscripts by adding a workflow we do not want
craigcomstock Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/craig.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: craigs check
on:
pull_request:

jobs:
dts:
secrets: inherit
uses: ./.github/workflows/deployment-tests.yml
permissions:
contents: read
pull-requests: read
23 changes: 17 additions & 6 deletions ci/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh
# setup build host on ubuntu 22
set -ex
PREFIX=/var/cfengine

# Github Actions provides machines with various packages installed,
# what confuses our build system into thinking that it's an RPM distro.
Expand Down Expand Up @@ -40,8 +40,19 @@ sudo apt-get -qy install bison flex binutils build-essential fakeroot ntp \
sudo apt-get -qq purge apache* "postgresql*" redis*

# packages needed for installing Mission portal dependencies
# remove any nodejs or node- packages currently in place
sudo apt-get remove -qy 'nodejs*' 'node-*'
# replace with exact version we want
wget -O - https://deb.nodesource.com/setup_20.x | sudo -E bash -
sudo apt-get install -qy nodejs

MINIMUM_NODE_VERSION=20
echo "Check for at least $MINIMUM_NODE_VERSION node version"
if command -v node; then
# vMAJOR.MINOR.PATCH
_major=$(node --version | cut -dv -f2 | cut -d. -f1)
if [ "$_major" -lt "$MINIMUM_NODE_VERSION" ]; then
echo "We need at least node version $MINIMUM_NODE_VERSION and found $_major. Will attempt to install from nodesource"

# remove any nodejs or node- packages currently in place
sudo apt-get remove -qy 'nodejs*' 'node-*'
# replace with exact version we want
wget -O - https://deb.nodesource.com/setup_20.x | sudo -E bash -
sudo apt-get install -qy nodejs
fi
fi
Loading