Feat/new auth workflow#248
Open
diocas wants to merge 4 commits into
Open
Conversation
Do not redirect on failure to renew session, instead show a modal. Allow login via pop-up. Fix flow also for embed mode.
- handleAuthError now checks userContextReady before deciding between the session expired modal (mid-session failure) and the access denied page (startup/login failure). Cleans up the anonymous-route fall-through that was triggering the modal during initial load or callback processing. - accessDenied page shows "Error signing in" with an appropriate hint when reached via reason=loginError (startup failures); retains the existing "Not logged in" copy for session-expiry navigations. - SessionExpiredModal redirects to home after a successful reconnect if the current route is a transient auth page (login, oidcCallback, etc.) - Logo on accessDenied, oidcCallback and SessionExpiredModal is wrapped in a router-link to home.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to change the auth workflow so that users are no longer redirected from the current page, they see a modal box saying that they are disconnected.
This is to ensure we stop losing any context due to redirections.
When disconnected, users are able to re-login via a pop-up. This should unblock all open tabs.
Its worked started on the first iteration from Rodrigo to bring pop-up auth for when web gets embedded (future implementation of the file picker).