Feat/recon update sortkey #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oed
reviewed
Jul 20, 2023
CIPs/cip-124.md
Outdated
| * `init_event_cid_bytes` is the CID of the first Event of the this stream. | ||
| * `event_height` is the "height" of the event InitEvent. For InitEvents this value is `0` else `prev.event_height + 1`. | ||
| * `event_cid_bytes` the CID of the event itself | ||
| * `event_height` is the "height" of the event InitEvent. For InitEvents this value is `1` else `prev.event_height + 1`. |
Contributor
There was a problem hiding this comment.
I thought we were not making the change from 0 to 1 on InitEvents?
oed
suggested changes
Jul 20, 2023
Contributor
oed
left a comment
oed
left a comment
There was a problem hiding this comment.
Should we add some language for "fencepost" in the ** Stream Set Ranges** section. Would also be good to update the examples there.
oed
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.