Conversation
|
|
@copilot review |
There was a problem hiding this comment.
Pull request overview
Adds OP Stack bridge support to the Celo CLI to move CELO between Ethereum L1 and Celo L2, including end-to-end withdraw lifecycle commands and supporting utilities/docs.
Changes:
- Introduces new
bridge:*CLI commands for deposit and multi-step withdrawals (init/prove/status/finalize). - Adds shared bridge network/config utilities (chain definitions, ABIs, status labels) plus unit tests.
- Adds CLI topic metadata and end-user documentation for bridge workflows.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/src/utils/bridge.ts | Adds bridge network config, OP Stack chain definitions, ABIs, and status labels used by commands. |
| packages/cli/src/utils/bridge.test.ts | Unit tests for network validation, config constants, chain selection, and status labels. |
| packages/cli/src/commands/bridge/deposit.ts | Implements L1→L2 CELO deposit flow (token lookup, approve, deposit). |
| packages/cli/src/commands/bridge/deposit.test.ts | Flag-validation tests for bridge:deposit. |
| packages/cli/src/commands/bridge/withdraw-init.ts | Implements L2 withdrawal initiation transaction. |
| packages/cli/src/commands/bridge/withdraw-prove.ts | Implements proof waiting/building and L1 prove submission. |
| packages/cli/src/commands/bridge/withdraw-status.ts | Implements human-readable withdrawal status + next-step guidance. |
| packages/cli/src/commands/bridge/withdraw-finalize.ts | Implements finalization/claim on L1 after challenge period. |
| packages/cli/src/commands/bridge/withdraw.test.ts | Flag-validation tests for all withdrawal commands. |
| packages/cli/package.json | Registers the bridge command topic in CLI metadata. |
| packages/cli/docs/bridge.md | Adds user documentation for deposit/withdraw workflows and status meanings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1f4a70ce9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59211d4e1b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #774 +/- ##
=======================================
Coverage 69.61% 69.61%
=======================================
Files 150 150
Lines 7075 7075
Branches 1163 1155 -8
=======================================
Hits 4925 4925
- Misses 2046 2098 +52
+ Partials 104 52 -52
🚀 New features to boost your workflow:
|
|
@copilot review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbd643bcde
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 709a92eadd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6017ecd28f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cde87409c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Description
Adds bridge commands to the Celo CLI for moving CELO tokens between Ethereum (L1) and Celo (L2) via the OP Stack bridge. This PR extends CLI with:
bridge:deposit— Deposit CELO from Ethereum L1 to Celo L2 (~15 min)bridge:withdraw-init— Initiate a withdrawal from Celo L2 to Ethereum L1bridge:withdraw-prove— Build and submit withdrawal proof on L1 (~1hr after init)bridge:withdraw-status— Check withdrawal status with human-readable output and next-step guidancebridge:withdraw-finalize— Claim funds on L1 after 7-day challenge periodTested
src/utils/bridge.test.ts— validates network config, contract addresses, chain IDs, status labelssrc/commands/bridge/deposit.test.ts— flag validation, address parsing, network rejection, signing requirementssrc/commands/bridge/withdraw.test.ts— flag validation for all 4 withdrawal commands (init, prove, status, finalize)How to QA
Prerequisites:
Test deposit (L1 → L2):
Verify: CELO appears on Celo Sepolia within ~15 minutes.
Test withdrawal (L2 → L1):
Related issues
PR-Codex overview
This PR introduces enhancements and tests for the
bridgecommands in the CLI, focusing on the process of bridging CELO between Ethereum (L1) and Celo (L2). It includes new functionalities for deposits, withdrawals, and status checks, along with improved error handling and validation.Detailed summary
bridgesection inpackage.jsonwith description.BridgeDepositandBridgeWithdrawcommands.BRIDGE_CONFIGfor network-specific configurations.bridge.test.ts.