-
Notifications
You must be signed in to change notification settings - Fork 32
fix rpc url timeouts #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rpc url timeouts #751
Conversation
🦋 Changeset detectedLatest commit: 232261d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Open to suggestions on the max time being to short. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
=======================================
Coverage 69.63% 69.63%
=======================================
Files 150 150
Lines 7071 7071
Branches 1151 1159 +8
=======================================
Hits 4924 4924
- Misses 2037 2060 +23
+ Partials 110 87 -23
🚀 New features to boost your workflow:
|
size-limit report 📦
|
1144b83 to
8ba97f2
Compare
|
should be mergable after #756 |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @celo/celocli@8.0.3 ### Patch Changes - [#751](#751) [`43f1e89`](43f1e89) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Set a max wait time when fetching community rpc provider metadata urls. - [#758](#758) [`f2eaa3a`](f2eaa3a) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - update celo-ledger-token-signer to fix transfer:dollars and support new mento token names - [#756](#756) [`fad32ac`](fad32ac) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Update minimum Node.js version requirement to >=20 and test on Node 24 - Updated dependencies \[[`f2eaa3a`](f2eaa3a), [`fad32ac`](fad32ac)]: - @celo/wallet-ledger@8.0.3 - @celo/viem-account-ledger@1.2.3 - @celo/wallet-hsm-azure@8.0.3 - @celo/wallet-local@8.0.3 ## @celo/dev-utils@0.1.3 ### Patch Changes - [#756](#756) [`fad32ac`](fad32ac) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Update minimum Node.js version requirement to >=20 ## @celo/wallet-base@8.0.3 ### Patch Changes - [#756](#756) [`fad32ac`](fad32ac) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - fix access of rawvalues ## @celo/wallet-hsm-aws@8.0.3 ### Patch Changes - Updated dependencies \[[`fad32ac`](fad32ac)]: - @celo/wallet-base@8.0.3 - @celo/wallet-hsm@8.0.3 - @celo/wallet-remote@8.0.3 ## @celo/wallet-hsm-azure@8.0.3 ### Patch Changes - Updated dependencies \[[`fad32ac`](fad32ac)]: - @celo/wallet-base@8.0.3 - @celo/wallet-hsm@8.0.3 - @celo/wallet-remote@8.0.3 ## @celo/wallet-hsm-gcp@8.0.3 ### Patch Changes - Updated dependencies \[[`fad32ac`](fad32ac)]: - @celo/wallet-base@8.0.3 - @celo/wallet-hsm@8.0.3 - @celo/wallet-remote@8.0.3 ## @celo/wallet-ledger@8.0.3 ### Patch Changes - [#758](#758) [`f2eaa3a`](f2eaa3a) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - update celo-ledger-token-signer to fix transfer:dollars and support new mento token names - Updated dependencies \[[`fad32ac`](fad32ac)]: - @celo/wallet-base@8.0.3 - @celo/wallet-remote@8.0.3 ## @celo/wallet-local@8.0.3 ### Patch Changes - Updated dependencies \[[`fad32ac`](fad32ac)]: - @celo/wallet-base@8.0.3 ## @celo/wallet-remote@8.0.3 ### Patch Changes - Updated dependencies \[[`fad32ac`](fad32ac)]: - @celo/wallet-base@8.0.3 ## @celo/viem-account-ledger@1.2.3 ### Patch Changes - [#758](#758) [`f2eaa3a`](f2eaa3a) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - update celo-ledger-token-signer to fix transfer:dollars and support new mento token names - [#756](#756) [`fad32ac`](fad32ac) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Update minimum Node.js version requirement from >=18 to >=20 ## @celo/wallet-hsm@8.0.3 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating several Celo packages to version `8.0.3` and `1.2.3`, along with modifying documentation and changelogs to reflect these updates. It also includes the removal of outdated changeset files. ### Detailed summary - Removed multiple changeset files. - Updated version for `@celo/wallet-hsm`, `@celo/wallet-base`, `@celo/wallet-local`, `@celo/wallet-remote`, `@celo/wallet-hsm-aws`, `@celo/wallet-hsm-gcp`, and `@celo/wallet-hsm-azure` to `8.0.3`. - Updated version for `@celo/viem-account-ledger` to `1.2.3`. - Updated changelogs for various packages reflecting new versions. - Modified documentation links and references to the new versions in multiple files. > The following files were skipped due to too many changes: `docs/command-line-interface/validatorgroup.md`, `docs/command-line-interface/lockedcelo.md`, `yarn.lock`, `docs/command-line-interface/governance.md`, `docs/command-line-interface/releasecelo.md`, `docs/command-line-interface/account.md` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
Command could hang when there were rpc providers with unresponsive metadata urls. Set a max wait time via promise.race and setTimeout so that the command can resolve
Related issues
validator:rpc-urlshang indefinitely #739PR-Codex overview
This PR focuses on enhancing the fetching of community RPC provider metadata URLs by introducing a maximum wait time of 6 seconds to prevent indefinite blocking.
Detailed summary
Promise.race.