Set up graph_query testing infrastructure for task graph#325
Set up graph_query testing infrastructure for task graph#325
Conversation
|
Check-perf-impact results: (000e2892abb21ddd1ae413a5c86d7d95) ❓ No new benchmark data submitted. ❓ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/print_graph.cc
Outdated
| fmt::format_to(std::back_inserter(dot), "{}->{}[{}];", d.node, tsk.tid, dependency_style(d.kind, d.origin)); | ||
| } | ||
| for(const auto& tsk : recorder.get_graph_nodes()) { | ||
| const char* shape = tsk->type == task_type::epoch || tsk->type == task_type::horizon ? "ellipse" : "box style=rounded"; |
There was a problem hiding this comment.
variable shape of type const char * can be declared const
| template <int Dims, typename Handler, typename Functor> | ||
| void dispatch_get_access(test_utils::mock_buffer<Dims>& mb, Handler& handler, access_mode mode, Functor rmfn) { | ||
| template <typename Builder, int Dims, typename Functor> | ||
| auto dispatch_get_access(Builder&& builder, test_utils::mock_buffer<Dims>& mb, access_mode mode, Functor rmfn) { |
There was a problem hiding this comment.
forwarding reference parameter builder is never forwarded inside the function body
test/task_graph_tests.cc
Outdated
|
|
||
| [[maybe_unused]] const task_id tid_8 = | ||
| test_utils::add_host_task(tt.tm, on_master_node, [&](handler& cgh) { buf_b.get_access<access_mode::read_write>(cgh, fixed<1>({0, 128})); }); | ||
| const auto tid_8 = tctx.master_node_host_task().read_write(buf_b, fixed<1>({0, 128})).submit(); |
There was a problem hiding this comment.
Value stored to tid_8 during its initialization is never read
Pull Request Test Coverage Report for Build 15470784509Details
💛 - Coveralls |
fknorr
left a comment
fknorr
left a comment
There was a problem hiding this comment.
Very cool! This makes me want to start the TDAG refactor.
| // TODO: Can we make this the base class of cdag / idag test contexts? | ||
| class tdag_test_context final : private task_manager::delegate { |
There was a problem hiding this comment.
How complicated would it actually be to have a common (interface) class for all four of these? We're copy pasting void device_compute() etc a lot. I'm not too worried about this since it's just test code, but would be neat to DRY it up if it's simple enough. I remember having to repeat the same test_context refactoring three times when I changed the fence surface API.
…ines-missing-std-forward and clang-analyzer-deadcode.DeadStores
GagaLP
force-pushed
the
tdag-testing-infrastructure
branch
from
ab1c78b to
229761d
Compare
|
Check-perf-impact results: (17d2daea565336edd0421cacd8138ced) ❓ No new benchmark data submitted. ❓ |
4 participants
This brings the TDAG (mostly) in line with CDAG and IDAG. What's missing is a hierarchical structure for
task_record, but since unlike for commands and instructions, a call tosubmit()only creates a single task (except for horizons) it turns out we don't really need this functionality anyway.