fix(contracts): fix #392 event hub emit gas and #395 flash loan reentry tests#482
Open
Dopezapha wants to merge 1 commit into
Open
fix(contracts): fix #392 event hub emit gas and #395 flash loan reentry tests#482Dopezapha wants to merge 1 commit into
Dopezapha wants to merge 1 commit into
Conversation
…reentry tests
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395
Closes #392
PR Description
Fixes #392 by optimizing the Event Hub capture path so each captured event is stored by event ID instead of rewriting a growing persistent event log vector on every emit. This keeps the emit/archive write path constant time while preserving existing event query behavior for indexers.
Fixes #395 by adding focused Flash Loan reentrancy coverage with malicious receiver contracts that attempt nested single and batch flash loans during callbacks. The flash loan entry points now also use a temporary-storage reentrancy lock as defense in depth, while the tests assert Soroban rejects same-contract reentry.
Changed
DataKey::EventLogEntry(event_id)and keepget_events,get_event, andget_events_by_contractcompatible.xcontractto satisfy Sorobansymbol_short!length limits.flash_loanandflash_loan_batch.