fix(smart-contracts): fix #399 yield reward edge cases and #391 event hub access control#481
Open
Dopezapha wants to merge 2 commits into
Open
Conversation
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #391
Closes #399
PR Description
Fixes #399 by preserving fractional yield farming rewards across both global accumulator updates and per-user claims, so integer rounding does not silently discard reward dust. The reward flow still uses O(1) per-share accounting, while invalid AMM share states are rejected before reward math runs.
Fixes #391 by centralizing Event Hub access checks and requiring registered source contracts to authorize event capture. Registered contracts can now emit through the hub via Soroban contract-invoker authorization, while unregistered or forged sources are rejected.
Changed
src/yield_farming/src/lib.rs.require_adminandrequire_registered_sourcehelpers insrc/event_hub/lib.rs.