Skip to content

Little improvements over origin accessor and writer deprecation warnings #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
santiagorodriguez96 merged 2 commits into from
Oct 23, 2025
Merged

Little improvements over origin accessor and writer deprecation warnings #487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70dd926
chore: improve `WebAuthn.origin` deprecation warning
santiagorodriguez96 Oct 22, 2025
477887f
chore: improve `WebAuthn.origin=` deprecation warning
santiagorodriguez96 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/webauthn/relying_party.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ def verify_authentication(
# DEPRECATED: This method will be removed in future.
def origin
warn(
"DEPRECATION WARNING: `WebAuthn.origin` is deprecated and will be removed in future. "\
"Please use `WebAuthn.allowed_origins` instead "\
"that also allows configuring multiple origins per Relying Party"
"DEPRECATION WARNING: `WebAuthn.origin` is deprecated and returns `nil` " \
"when `WebAuthn.allowed_origins` contains more than one origin. " \
"It will be removed in future. Please use `WebAuthn.allowed_origins` instead."
)

allowed_origins.first if allowed_origins&.size == 1
Expand All @@ -137,8 +137,8 @@ def origin=(new_origin)
return if new_origin.nil?

warn(
"DEPRECATION WARNING: `WebAuthn.origin` is deprecated and will be removed in future. "\
"Please use `WebAuthn.allowed_origins` instead "\
"DEPRECATION WARNING: `WebAuthn.origin=` is deprecated and will be removed in future. "\
"Please use `WebAuthn.allowed_origins=` instead "\
"that also allows configuring multiple origins per Relying Party"
)

Expand Down
Loading