1546: fixed issue reporting for DDF00125#1736
Merged
Merged
Conversation
alexfurmenkov
changed the title
alexfurmenkov
requested review from
ASL-rmarshall,
RamilCDISC,
SFJohnson24 and
gerrycampion
SFJohnson24
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following changes made it possible to report errors for schema validation
report made on pilot_LLZT_protocol_DIRTY.json with removed comma to ensure correctness of json structure
pilot-report-pre-changes.json
pilot-report-after-changes.json
Looks like these test failures are caused by errors now being recorded correctly, whereas previously they weren’t. The failures are only additional expected errors, so I think we should check whether the test suite/test data needs to be updated.
usdm_negative_comparison.json