WIP: action to check engine against published rules#1700
Draft
alexfurmenkov wants to merge 10 commits intomainfrom
Draft
WIP: action to check engine against published rules#1700alexfurmenkov wants to merge 10 commits intomainfrom
alexfurmenkov wants to merge 10 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+48
to
+60
| - name: Checkout cdisc-open-rules | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| repository: cdisc-org/cdisc-open-rules | ||
| ref: ${{ inputs.rules_ref || 'main' }} | ||
| path: open-rules | ||
| # If cdisc-open-rules is private, add a PAT secret: | ||
| # token: ${{ secrets.CDISC_OPEN_RULES_TOKEN }} | ||
|
|
||
| # ----------------------------------------------------------------------- | ||
| # 3. Set up Python | ||
| # ----------------------------------------------------------------------- | ||
| - name: Set up Python 3.12 |
Collaborator
gerrycampion
left a comment
gerrycampion
left a comment
There was a problem hiding this comment.
This is looking really nice, but I have some comments
| uses: actions/checkout@v6 | ||
| with: | ||
| repository: cdisc-org/cdisc-rules-engine | ||
| ref: ${{ inputs.engine_ref || github.sha }} |
Collaborator
There was a problem hiding this comment.
remove ref for engine checkout. It should use whatever the default is.
gerrycampion
reviewed
May 7, 2026
Collaborator
gerrycampion
left a comment
gerrycampion
left a comment
There was a problem hiding this comment.
The summary and detailed outputs look awesome. I have one comment, sorry I didn't pickup on this earlier. Hopefully it is an easy conversion for ai.
Comment on lines
+94
to
+110
| # Write the JSON-line parser once; called once per test case in the loop below | ||
| cat > /tmp/parse_case.py << 'PYEOF' | ||
| import sys, json, shlex | ||
| d = json.load(sys.stdin) | ||
| for k, v in [ | ||
| ('CASE_RULE', d['rule']), | ||
| ('CASE_TYPE', d['type']), | ||
| ('CASE_NUM', str(d['num'])), | ||
| ('EXEC_OK', '\u2705' if d['exec'] else '\u274c'), | ||
| ('EXPECTED', str(d.get('expected', ''))), | ||
| ('GOT', str(d.get('got', ''))), | ||
| ('MATCH', '\u2705' if d.get('match') else '\u274c'), | ||
| ('DIFF_FILE', str(d.get('diff', ''))), | ||
| ('STDERR_FILE', str(d.get('stderr', ''))), | ||
| ]: | ||
| print(k + '=' + shlex.quote(v)) | ||
| PYEOF |
Collaborator
There was a problem hiding this comment.
This should just go in a python file in /scripts. In fact, I think this entire Run validation for all Published rules job after the first call to run_validation.sh should go in a python file for easier maintenance. I would copy this utility to simplify markdown table creation: https://github.com/cdisc-org/CORE_Test_Suite/blob/main/scripts/markdown_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workflow to run validation for all published rules, comparing with benchmark validation results
cdisc-org/cdisc-open-rules#22 with changes to allow validation from this repo