1669: stop execution when multiple --data options are provided#1684
Merged
Conversation
alexfurmenkov
requested review from
RamilCDISC,
SFJohnson24 and
gerrycampion
and removed request for
gerrycampion
gerrycampion
requested changes
Apr 6, 2026
Collaborator
There was a problem hiding this comment.
I don't think we should update the cli. If we update for this option, we need to update for all options where multiple=False. It behaves the same way any typical cli would behave when multiple of the same option are provided.
| loaded metadata and rules | ||
| -ps, --pool-size INTEGER Number of parallel processes for validation | ||
| -d, --data TEXT Path to directory containing data files | ||
| -d, --data TEXT Path to directory containing data files. Can can only be provided once. |
Collaborator
There was a problem hiding this comment.
Typo. maybe give more info: "Should only be provided once. If provided more than once, only the last value will be recorded."
alexfurmenkov
changed the title
gerrycampion
reviewed
Apr 7, 2026
| "--data", | ||
| required=False, | ||
| multiple=True, | ||
| help=f"Path to directory containing data files ({VALIDATION_FORMATS_MESSAGE})", |
Collaborator
There was a problem hiding this comment.
Sorry, i missed this before. We should update the help text as well.
gerrycampion
requested changes
Apr 7, 2026
gerrycampion
approved these changes
Apr 7, 2026
RamilCDISC
approved these changes
Apr 7, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The documentation and help text is properly updated to reflect that only one -data option is allowed. In case of multiple the last one will be used. This fulfills the AC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.