#1652 wildcard replacement with domain on grouping_variables#1674
Merged
Conversation
RamilCDISC
requested changes
Mar 31, 2026
| # Original case: explicit column name, no wildcard | ||
| (["SETCD"], None, "SETCD"), | ||
| # Wildcard case: "--PARMCD" replaced with domain "TX" → "TXPARMCD" | ||
| (["--PARMCD", "SETCD"], "TX", "SETCD"), |
Collaborator
There was a problem hiding this comment.
The test case is still covering SETCD not '--PARMCD' so wildcard replacement code is not being tested fully. Could you please add a case where expected is TXPARMCD.
Collaborator
There was a problem hiding this comment.
agree with Ramil, would like a test where it is grouped only on --PARMCD
would also like to see TXPARMCD varied within SETCD for the test where you group on both to show that the grouping actually is contributing
RamilCDISC
approved these changes
Apr 2, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds wild card replacement with domain on grouping variables. The updates were validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Reviewing the updated tests for coverage.
- Ensuring all tests pass.
- Running manual validation on using dev editor with positive dataset
- Running manual validation on dev editor with negative dataset.
SFJohnson24
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added wildcard replacement in
generate_targeted_error_objectfor group sensitivity.