error handling and removed if conditional#1670
Merged
Merged
Conversation
RamilCDISC
requested changes
Mar 17, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The AC and PR description both requires removal of if conditional which I could not find in the changes. Could you also please add a case for dask dataset.
Collaborator
Author
|
@RamilCDISC sorry I was doing A/B testing and forgot to remove the if statement. removed it |
gerrycampion
requested changes
Mar 18, 2026
gerrycampion
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the If conditional for the pivot logic that is needed for other supp domains to collapse, previously limited to SUPPDM only. After pivoting QNAM values into columns, process_supp produces one sparse row per original QNAM record. The groupby/agg collapse is required for all SUPP domains to produce a single wide row per unique key.
I tested this on cg0371, fb0101, FB5801, and CG0531 for their various supp conditions.
I also added logic for when common keys (contained in both parent and supp) have 0 alignment--a preprocessingerror is thrown to prevent silent failing, and raise the issue in the report.