Skip to content

688: update tests#1666

Merged
SFJohnson24 merged 16 commits into
mainfrom
688-update-tests
Apr 8, 2026
Merged

688: update tests#1666
SFJohnson24 merged 16 commits into
mainfrom
688-update-tests

Conversation

@alexfurmenkov
Copy link
Copy Markdown
Collaborator

@alexfurmenkov alexfurmenkov commented Mar 13, 2026

No description provided.

@alexfurmenkov alexfurmenkov requested review from RamilCDISC, SFJohnson24 and gerrycampion and removed request for gerrycampion March 23, 2026 14:31
@alexfurmenkov alexfurmenkov linked an issue Mar 23, 2026 that may be closed by this pull request
TestCoreIssue363.test_post_request failing #688
Closed
@alexfurmenkov
Copy link
Copy Markdown
Collaborator Author

alexfurmenkov commented Mar 23, 2026 •
edited
Loading

The tests from test_Issues are now running, but some tests that cannot be quickly modified to work are being skipped.

RamilCDISC
RamilCDISC requested changes Mar 23, 2026
View reviewed changes
Comment thread .github/workflows/test-unit.yml Outdated
@alexfurmenkov alexfurmenkov marked this pull request as ready for review March 24, 2026 10:14
@RamilCDISC
Copy link
Copy Markdown
Collaborator

RamilCDISC commented Mar 30, 2026

One reason for not adding these tests as part of CI before was that these tests are slow. The time for CI-unit tests will increase a lot. If @gerrycampion and @SFJohnson24 say the time increase is acceptable the PR is good for QA validation. My initial intent was that developers can run these if they want to test locally.

RamilCDISC
RamilCDISC approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates regression testing. The goal is to update and make them part of CI pipeline under unit tests. Some tests are skipped for now. These need optimization. I will make a new PR to fix and update those.

Successful CI pipeline on this PR shows tests ran successfully.

@SFJohnson24 SFJohnson24 merged commit f4c4776 into main Apr 8, 2026
12 checks passed
@SFJohnson24 SFJohnson24 deleted the 688-update-tests branch April 8, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SFJohnson24 SFJohnson24 SFJohnson24 approved these changes

@RamilCDISC RamilCDISC RamilCDISC approved these changes

@gerrycampion gerrycampion Awaiting requested review from gerrycampion

Assignees

@RamilCDISC RamilCDISC

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestCoreIssue363.test_post_request failing

3 participants

@alexfurmenkov @RamilCDISC @SFJohnson24