Skip to content

Move VALIDATION_FORMATS_MESSAGE from core.py to constants package #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SFJohnson24 merged 5 commits into from
Feb 2, 2026
Merged

Move VALIDATION_FORMATS_MESSAGE from core.py to constants package #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
679648d
Move VALIDATION_FORMATS_MESSAGE from core.py to constants package
RakeshBobba03 Jan 29, 2026
2360138
Merge branch 'main' into 1575-move-validation-formats-constant
RakeshBobba03 Jan 29, 2026
a473ac8
Auto-updated branch with latest changes from main
SFJohnson24 Jan 30, 2026
71ad750
Auto-updated branch with latest changes from main
SFJohnson24 Jan 30, 2026
a041e5b
Merge branch 'main' into 1575-move-validation-formats-constant
SFJohnson24 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cdisc_rules_engine/constants/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,7 @@
NULL_FLAVORS = ["", None, {None}, [], {}, np.nan]

KNOWN_REPORT_EXTENSIONS = [".json", ".xlsx", ".xls"]

VALIDATION_FORMATS_MESSAGE = (
"SAS V5 XPT, Dataset-JSON (JSON or NDJSON), or Excel (XLSX)"
)
5 changes: 2 additions & 3 deletions core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,12 @@
get_rules_cache_key,
validate_dataset_files_exist,
)
from cdisc_rules_engine.constants import VALIDATION_FORMATS_MESSAGE
from cdisc_rules_engine.enums.dataformat_types import DataFormatTypes
from scripts.list_dataset_metadata_handler import list_dataset_metadata_handler
from scripts.run_validation import run_validation
from version import __version__

VALIDATION_FORMATS_MESSAGE = (
"SAS V5 XPT, Dataset-JSON (JSON or NDJSON), or Excel (XLSX)"
)
DEFAULT_CACHE_PATH = os.path.join(
os.path.dirname(os.path.abspath(__file__)), DefaultFilePaths.CACHE.value
)
Expand Down
Loading