Skip to content

resolve double testing with CI#1553

Merged
SFJohnson24 merged 1 commit into
mainfrom
doubletest
Jan 22, 2026
Merged

resolve double testing with CI#1553
SFJohnson24 merged 1 commit into
mainfrom
doubletest

Conversation

@SFJohnson24
Copy link
Copy Markdown
Collaborator

@SFJohnson24 SFJohnson24 commented Jan 21, 2026 •
edited
Loading

this PR does 2 things:

  • resolve the double trigger of test suite on a PR.
  • remove the test suite from the CI as I was able to get the test suite to run on external PRs the current way it is triggered outside of the CI action, but when it passes the PR head from CI to test suite, it does not have the token to get the test suite repo when it is an outside PR.

@SFJohnson24 SFJohnson24 self-assigned this Jan 21, 2026
gerrycampion
gerrycampion approved these changes Jan 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gerrycampion gerrycampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good assuming the failing e2e test is unrelated?

@SFJohnson24 SFJohnson24 merged commit 769d8a1 into main Jan 22, 2026
18 of 21 checks passed
@SFJohnson24 SFJohnson24 deleted the doubletest branch January 22, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gerrycampion gerrycampion gerrycampion approved these changes

Assignees

@SFJohnson24 SFJohnson24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SFJohnson24 @gerrycampion