1174: json load fallback logic. update-cache encoding parameter. #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encoding parameter to update-cache operation
alexfurmenkov
changed the title
SFJohnson24
requested changes
Jan 16, 2026
Collaborator
There was a problem hiding this comment.
This looks good-- can you update the readme to reflect the new command and describe the fallbacks. I would also make a note regarding the encodings we can currently run/expect as #1022 is still not completed so even if they can put any encoding into the cache, they will not be able to run them
SFJohnson24
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added fallback logic while reading json. cache input file encoding can be specified with parameter.