1501: fix JSON format report creation when -rr flag is provided #1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-raw-report # Conflicts: # tests/QARegressionTests/test_Issues/test_CoreIssue1501.py
alexfurmenkov
changed the title
RamilCDISC
approved these changes
Jan 13, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR fixes the bug where -rr flag was used when run a validation. Resulted in an error. The PR was validated by:
- Reviewing PR for any unwanted code or comments.
- Reviewing PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring all relevant testing is updates.
- Ensuring updated testing covers the test cases.
- Running manual validation locally with
- -rr flag set
- -rr flag disabled
- -rr flag set with output format as excel
- -rr flag set with output format as json
- -rr flag set with excel dataset
- -rr flag set with json dataset
- -rr flag set with ndjson dataset
- -rr flag set xpt dataset
- -rr flag set with output path containing excel extension
- -rr flag set with output path containing no extension
- -rr flag set with output path containing json extension
- -rr flag set with output path a directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.