Skip to content

Conversation

@SFJohnson24
Copy link
Collaborator

@SFJohnson24 SFJohnson24 commented Jan 12, 2026

  • this PR resolves the e2e testing concurrency issue when multiple branches try to deploy to the same dev slot.

  • https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git When using pull_request_target, the workflow runs with access to secrets but in the base repository's context, which allows it to clone your private CORE_Test_Suite repository. This does create a security risk but our security settings require approval to run the CI for external PRs so I believe the warnings from codeQL would not be relevant as we would screen/manually review the PR code for malicious code before running the action

@SFJohnson24 SFJohnson24 merged commit f92d15e into main Jan 12, 2026
10 of 11 checks passed
@SFJohnson24 SFJohnson24 deleted the autoupdate branch January 12, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants