1487: Fix engine crash when selected rule is not applicable for version#1526
Merged
Conversation
alexfurmenkov
changed the title
…/cdisc-org/cdisc-rules-engine into 1487-rule-version-mismatch-crash
RamilCDISC
approved these changes
Jan 15, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR fixes the engine crash when a selected rule is not applicable. The PR was validated by:
- Reviewing PR for any unwanted code or changes.
- Reviewing PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring all related testing is updated.
- Running manual testing in CLI covering cases.
- getting rule form cache specifying rule using -r which exists in the specified standard.
- getting rule form cache specifying rule using -r which does not exists in the specified standard.
- getting rule form local directory specifying rule using -r which exists in the specified standard.
- getting rule form local directory specifying rule using -r which does not exists in the specified standard.
- getting rule form cache not specifying rule using -r which exists in the specified standard.
- getting rule form cache not specifying rule using -r which does not exists in the specified standard.
- getting rule form local directory not specifying rule using -r which exists in the specified standard.
- getting rule form local directory not specifying rule using -r which does not exists in the specified standard.
SFJohnson24
approved these changes
Jan 16, 2026
Collaborator
SFJohnson24
left a comment
SFJohnson24
left a comment
There was a problem hiding this comment.
CORE-Report-2026-01-16T13-04-07.xlsx
PR resolves issue described in ticket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.