reorder readme, fix tests #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrycampion
requested changes
Jan 8, 2026
gerrycampion
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was in the process of giving the readme a reorg for more logical flow for the ClI. This PR includes that.
The changes to close down manager at the end of a validation causes issues as 2 cache_managers are created for each subsequent validation run with the single command. Python's multiprocessing leaves behind global state from the first validation. The first validation thus affects the multiprocessing infrastructure of the second. This resulted in a
BrokenPipeError: [WinError 232] The pipe is being closed.the pipes from the first manager are closed, and the second manager can't properly establish new ones in the same process. Splitting the tests splits the processes so this issue does not occur.see: https://github.com/cdisc-org/cdisc-rules-engine/actions/runs/20826120159