Skip to content

1045 define dataset variables missing documentation #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RamilCDISC merged 5 commits into from
Jan 6, 2026
Merged

1045 define dataset variables missing documentation #1509

RamilCDISC merged 5 commits into from
Jan 6, 2026

Conversation

@RakeshBobba03
Copy link
Collaborator

@RakeshBobba03 RakeshBobba03 commented Jan 2, 2026 •
edited
Loading

(Issue #1045 )
Adds documentation in MetaVariables.md for define_dataset_variables and define_dataset_variable_order, clarifying that define_dataset_variables uses XML document order while define_dataset_variable_order sorts by OrderNumber when present.

@RakeshBobba03 RakeshBobba03 marked this pull request as ready for review January 2, 2026 18:50
@RakeshBobba03 RakeshBobba03 linked an issue Jan 2, 2026 that may be closed by this pull request
define_dataset_variables missing documentation #1045
Closed
RamilCDISC
RamilCDISC requested changes Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add update the MetaVariables.json file too.

@RakeshBobba03
Copy link
Collaborator Author

RakeshBobba03 commented Jan 6, 2026 •
edited
Loading

Could you please add update the MetaVariables.json file too.

PR for issue #791 already added define_dataset_variables to MetaVariables.json as part of the code changes. PR for issue #1045 is focused on documentation updates in MetaVariables.md.Since these are related issues (791 for code, 1045 for docs), the JSON schema update is already covered in #791. Once #791 is merged, #1045 will inherit that change. Let me know if you'd prefer a different approach!

RamilCDISC
RamilCDISC approved these changes Jan 6, 2026
View reviewed changes
Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated as required.

@RamilCDISC RamilCDISC merged commit 32b3828 into main Jan 6, 2026
11 checks passed
@RamilCDISC RamilCDISC deleted the 1045-define_dataset_variables-missing-documentation branch January 6, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RamilCDISC RamilCDISC RamilCDISC approved these changes

@gerrycampion gerrycampion Awaiting requested review from gerrycampion

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

define_dataset_variables missing documentation

3 participants

@RakeshBobba03 @RamilCDISC