-
Notifications
You must be signed in to change notification settings - Fork 27
Allow updating cache without apikey #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nhaydel
wants to merge
18
commits into
main
Choose a base branch
from
allow-update-cache-without-apikey
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+141
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrycampion
requested changes
Jan 7, 2026
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you should add documentation describing the new behavior in this section: https://github.com/cdisc-org/cdisc-rules-engine/blob/allow-update-cache-without-apikey/README.md#updating-the-cache-update-cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is apart of the membership levers project.
We want to allow users who don't know their api key or don't have a valid api key to still pull rules from the library and update the cache. This PR just updates the cache populator to allow fetching rules only as well as handle any failed requests to the cdisc library api.
The expected outcomes are:
save_rules_locallyfunction should be run.Note
Since the ability to request rules from the production library api without an api key has not been released you will see 401 responses from the rules endpoint as well. This should be resolved once that functionality is released. If you want to ensure the rules are updated, you can use the dev environment.