make CLI work on Linux and other minor fixes #1496
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you please resolve the conflicts on this branch. Thank you. |
Author
|
Thanks @RamilCDISC - would this work now? |
SFJohnson24
reviewed
Jan 12, 2026
SFJohnson24
reviewed
Jan 12, 2026
SFJohnson24
reviewed
Jan 12, 2026
SFJohnson24
reviewed
Jan 12, 2026
SFJohnson24
reviewed
Jan 12, 2026
SFJohnson24
requested changes
Jan 12, 2026
Collaborator
SFJohnson24
left a comment
SFJohnson24
left a comment
There was a problem hiding this comment.
Please see comments from review.
Author
|
thanks @SFJohnson24 for reviewing and giving me helpful comments and pointers. I responded to your messages and fixed the issues you identified. Let me know what else you would like to see approve this PR. |
Collaborator
|
@raamana see responses-- you will also need to update your branch with main and resolve conflicts if there are any |
Author
|
Thanks Samuel - I think I've addressed all your comments - let me know if not :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see that this can't be merged automatically, but I am creating this to give the maintainers a sense of changes I have made. Perhaps these were fixed in the changes I am yet to sync (will review them shortly).
thanks for sharing this openly and maintaining it.