manager shutdown #1490
Merged
manager shutdown #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
requested changes
Dec 16, 2025
scripts/run_validation.py
Outdated
| engine_logger.info(" Report generated, Cleaning up intermediate files") | ||
| for file in created_files: | ||
| engine_logger.info(f"Deleting file {file}") | ||
| os.remove(file) |
Collaborator
There was a problem hiding this comment.
I think we should keep file parquet file deleting in final block because any exception that will occur before this part will leave the files undeleted.
Collaborator
Author
There was a problem hiding this comment.
moved, i also added it to a try/except to warn user if a file fails to delete
RamilCDISC
approved these changes
Dec 18, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR refactors the run validation code to ensure that the pool processes are closed properly once the validation completes. The Validation was done by:
- Reviewing the PR for any unwanted code or comments.
- Ensuring all unit and regression testing pass.
- Ensuring the refactored code fully covers the previous code.
- Running manual validations using CLI to ensure proper execution.
- Validation using large datasets to ensure compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
run_validationfunction inscripts/run_validation.pyto improve resource management and code readability. The main change is ensuring that theCacheManageris properly shut down after validation, even if an exception occurs, by wrapping the main logic in atry/finallyblock. Additionally, several lines are reformatted for better readability.Resource management improvements:
run_validationin atry/finallyblock to guarantee thatmanager.shutdown()is called, ensuring proper cleanup of resources. [1] [2]