-
Notifications
You must be signed in to change notification settings - Fork 27
hotfix20251216: #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hotfix20251216: #1488
Conversation
EfrosIonelu
commented
Dec 16, 2025
- fix: 'NoneType' object has no attribute 'lower'
- fix: 'NoneType' object has no attribute 'lower'
|
Could you please add more details regarding why this fix is being made. What is the issue that was observed. If there is a ticket for it could you please attach it? |
|
I tried to validate a non-completed json, an i hit an error there |
SFJohnson24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also tagged @ASL-rmarshall as he is far more familiar with USDM than I am
| dataset_dict = {} | ||
| for path in metadata: | ||
| entity = path["entity"] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seem null/none entities are meant to go through to the codeblock on 467 per the comment on 466. Could this be resolved simply by changing line 464 to if entity and entity.lower() == "code": ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can make this change if there will be no errors after
ASL-rmarshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before approving this change, I'd want to know why the entity was not found/assigned. Please either provide a copy of the "non-completed json" file or describe in more detail what was missing.
I finished a month ago, my part on the project that was using https://github.com/transcelerate/ddf-sdr-api Version of this project on our server, was updated by your team, as project is growing. But as i want to help you: i don't have access to debug that error, but i think is the same error as before. Hope it helps. |
|
@pendingintent can you take a look a this? |