1442: add filetype option to validate type of data #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfurmenkov
changed the title
RamilCDISC
requested changes
Dec 15, 2025
core.py
Outdated
| help=f"Path to directory containing data files ({VALIDATION_FORMATS_MESSAGE})", | ||
| ) | ||
| @click.option( | ||
| "-filetype", |
Collaborator
There was a problem hiding this comment.
Could you please make this similar to other flags. full name with '--' and a short with '-'. You can use '-f' and '--filetype'
RamilCDISC
approved these changes
Dec 18, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds a few flag that lets you control which files engine works on in the selected dataset folder. Not specifying this flag results in previous behaviour of engine.
The validation was done by:
- Reviewing the PR for any unwanted code or logic.
- Reviewing the PR in accordance with AC.
- Ensuring all unit and regression tests pass.
- Ensuring all related testing is updated and new tests are added.
- Running engine locally for manual validation.
- Verifying the edge case of empty directory.
- Verifying the edge case of multiple -ft flags.
- Verifying edge case of invalid file type.
|
@alexfurmenkov , @RamilCDISC , thanks for adding the --filetype flag. I'm testing the last release v0.14.1 on a linux box and so far it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.