added domain failure to find exception #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
approved these changes
Dec 15, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates the domain failure from simple log to an exception which will cause the rule to skip. The PR was validated by:
- Reviewing the PR for any unwanted code or. comments.
- Reviewing the PR logic in accordance with AC.
- Validating all unit and regression tests pass.
- Validating all relevant testing is updated.
- Validating the engine execution on rules where the bug was identified.
- Running manual validation using the postive datasets.
- Running validations using the negative datasets.
- Validating the case where the required domain is missing.
- Validating the case where the domain is present but the concerned column is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes when a domain is given for an operation that is not the current dataset. If that dataset doesnt exist, we throw an exception causing a ruleskip instead of executing the rule as this looked like the rule was execute successfully except for a log:
CORE-Report-2025-12-12T13-53-52.xlsx
Datasets_nods.json
Rule_underscores.json