-
Notifications
You must be signed in to change notification settings - Fork 27
Library Changes #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Library Changes #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
approved these changes
Dec 20, 2025
Collaborator
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR updates how required and permitted variables are found for a domain. The updates were validated by:
- Reviewing the PR for any unwanted code or changes.
- Reviewing the PR in accordance with AC.
- Validating all unit and regression testing pass.
- Validating all testing updates were as required.
- Ensuring new tests added if required.
- Running manual validation using positive datasets.
- Running manual validations using negative datasets.
- Validating edge cases of missing values.
- Manually confirming the required and permissible variable fetched by engine with the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
This also updates the unit tests-- correctly grabbing the variables from the general observation class, sorting on ordinal for the identifier, and adding the class variables into it. The test for required removes the variables that were getting pulled in from my first bullet as their requirement should be defined via the library variable data and not hardcoding.
to test: you will run these with trial data I will provide you.