Skip to content

Conversation

@SFJohnson24
Copy link
Collaborator

@SFJohnson24 SFJohnson24 commented Dec 2, 2025

this PR updates the template with Nick's formatted version. It also changes the dataset in dataset details to the name property over the filename as was requested in rule author meeting

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it this will fall under current ticket but because the new template was added in the connected issue. I observed that the conformance details tab in the report template shows none for Issue Limit per Rule. But the engine put 0 when limit is not specified in command line.

Please let me know if this will be fixed in a separate ticket or we can update it in the current PR?

@SFJohnson24
Copy link
Collaborator Author

@RamilCDISC I updated the env for MAX_ERRORS_PER_RULE, updated our example and moved the parsing logic to the utils (as scripts are not put into our pypi package). This should resolve the conformance details tab issue you noticed.

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the reporting to match the updated template. The changes were validated by:

  1. Reviewing the PR code for any unwanted code or comments.
  2. Reviewing the PR logic in accordance with AC.
  3. Ensuring the changes are consistent with previous code.
  4. Ensuring all unit and regression tests pass.
  5. Ensuring all related testing is updated.
  6. Running manual test locally and comparing the excel report with the template.
  7. Running manual tests locally and ensuring json report is also updated accordingly.
  8. Validating the Issue limit per dataset and per rule keys for default values.
  9. Validating the issue limit per dataset and per rule keys for values set through CLI and env variables.

@RamilCDISC RamilCDISC merged commit a2c9255 into main Dec 11, 2025
11 checks passed
@RamilCDISC RamilCDISC deleted the dataset_template branch December 11, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants