-
Notifications
You must be signed in to change notification settings - Fork 27
new template, changed filename origin #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if it this will fall under current ticket but because the new template was added in the connected issue. I observed that the conformance details tab in the report template shows none for Issue Limit per Rule. But the engine put 0 when limit is not specified in command line.
Please let me know if this will be fixed in a separate ticket or we can update it in the current PR?
|
@RamilCDISC I updated the env for MAX_ERRORS_PER_RULE, updated our example and moved the parsing logic to the utils (as scripts are not put into our pypi package). This should resolve the conformance details tab issue you noticed. |
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR updates the reporting to match the updated template. The changes were validated by:
- Reviewing the PR code for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring the changes are consistent with previous code.
- Ensuring all unit and regression tests pass.
- Ensuring all related testing is updated.
- Running manual test locally and comparing the excel report with the template.
- Running manual tests locally and ensuring json report is also updated accordingly.
- Validating the Issue limit per dataset and per rule keys for default values.
- Validating the issue limit per dataset and per rule keys for values set through CLI and env variables.
this PR updates the template with Nick's formatted version. It also changes the dataset in dataset details to the name property over the filename as was requested in rule author meeting