Skip to content

1204: improve error message if dataset files are not found #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SFJohnson24 merged 3 commits into from
Nov 20, 2025
Merged

1204: improve error message if dataset files are not found #1441

SFJohnson24 merged 3 commits into from
Nov 20, 2025

Conversation

@alexfurmenkov
Copy link
Collaborator

@alexfurmenkov alexfurmenkov commented Nov 18, 2025 •
edited
Loading

Now, in case the datasets are not found the engine will exit with code 2 and output:

[ERROR 2025-11-18 18:07:06,565 - utils.py:452] - Files dataset.json, dataset1.json are not found

Process finished with exit code 2

@alexfurmenkov alexfurmenkov linked an issue Nov 18, 2025 that may be closed by this pull request
Error message is not user friendly when using dp and the path doesn't exist #1204
Closed
@SFJohnson24 SFJohnson24 self-assigned this Nov 20, 2025
SFJohnson24
SFJohnson24 approved these changes Nov 20, 2025
View reviewed changes
Copy link
Collaborator

@SFJohnson24 SFJohnson24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR passes high level code review. Correctly reports when one or multiple DP does not exist or mixed case when one exists and another does not in multiple -dp.

@SFJohnson24 SFJohnson24 merged commit 7c73ba0 into main Nov 20, 2025
11 checks passed
@SFJohnson24 SFJohnson24 deleted the 1204-improve-error-message-in-case-dataset-file-doesnt-exist branch November 20, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SFJohnson24 SFJohnson24 SFJohnson24 approved these changes

@gerrycampion gerrycampion Awaiting requested review from gerrycampion

@RamilCDISC RamilCDISC Awaiting requested review from RamilCDISC

@ASL-rmarshall ASL-rmarshall Awaiting requested review from ASL-rmarshall

Assignees

@SFJohnson24 SFJohnson24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error message is not user friendly when using dp and the path doesn't exist

3 participants

@alexfurmenkov @SFJohnson24