1403: Update the cache location to be relative to the folder containing core.py #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfurmenkov
changed the title
RamilCDISC
approved these changes
Nov 17, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates the cache path to be relative to core file instead of folder. This implements the solution suggested in the AC and fulfills the requirements. All testing pass.
RamilCDISC
deleted the
1403-make-cache-location-relative-to-core.py-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the problem that @ASL-rmarshall has reported for the
update-cachecommand also exists for all other commands listed incore.py, so this update fixes other commands as well.I've ran the command from different locations (like my laptop user root
(.venv) alekseifurmenkov@MacBook-Pro-Aleksei ~ % python PycharmProjects/cdisc-rules-engine/core.py update-cache --apikey ...) and it works fine.