1402 CG0546 support multi-key param update #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RakeshBobba03
requested review from
RamilCDISC,
Copilot and
gerrycampion
and removed request for
Copilot
gerrycampion
approved these changes
Nov 12, 2025
RamilCDISC
approved these changes
Nov 13, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR updates the 'within' to a list while also preserving the functionality of it being treated as string. This ensures no other rules that uses within as string break. The PR was validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR updated logic in context with AC.
- Ensuring all unit and regression tests pass.
- Ensuring all related testing has been updates.
- Ensuring new relevant testing has been added.
- Manual testing by running with positive dataset in dev editor.
- Manual testing by running negative dataset in dev editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1402: Updated
target_is_sorted_byto normalize thewithinparameter to an ordered list, then reuse the existing sort-and-group flow so it handles one or many grouping keys without materializing the entire dataset. Adjusted the post-group alignment to drop levels only when the grouped result is multi-indexed, keeping Pandas and Dask behavior in sync. Extended the operator schema and reference guide to document the list form, and added positive/negative multi-key tests for both PandasDataset and DaskDataset to cover the regression that affected rule CG0546.