version #1427
Merged
version #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASL-rmarshall
approved these changes
Nov 11, 2025
Collaborator
ASL-rmarshall
left a comment
ASL-rmarshall
left a comment
There was a problem hiding this comment.
I've reviewed the code changes and they look good. I've also run all available USDM CT rules before and after the fix and confirmed that the fix resolves the issue.
alexfurmenkov
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cg0288 PR broke all DDF Codelist term rules-- the issue is due to ct_version getting grabbed and not version. I have ported get_codelist_attributes to using version instead of ct_version and restored the old attribute grab.
this PR restores functionality while continuing to have cg0288 work.
cg0288 report: CORE-Report-2025-11-11T12-17-08.xlsx
ddf00142 - CORE-Report-2025-11-11T12-19-09.xlsx
to test: run ddf rules with codelist_term / codelist_extensible operators
run cg0288 with the below updated logic:
Rule_underscores.json