-
Notifications
You must be signed in to change notification settings - Fork 27
Cg0562 #1422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cg0562 #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
requested changes
Nov 10, 2025
gerrycampion
requested changes
Nov 10, 2025
gerrycampion
approved these changes
Nov 13, 2025
RamilCDISC
approved these changes
Nov 13, 2025
Collaborator
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR updates the way '--' are handled and adds regex logic. The PR was validated by:
- Reviewing the PR for any unwanted code or comment.
- Reviewing the updated logic in accordance with AC.
- Ensuring all unit and regression tests pass.
- Ensuring all relevant testing is updated.
- Validating the AC using positive datastes in dev editor.
- Validating the AC using negative datasets in dev editor.
- Validating the edge cases related to regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test data:
pos.json
Rule_underscores.json
neg.json
This PR adds wildcard logic for all operations as well as allowing the regex argument = for the above rule.
This pull request introduces improvements to how domain wildcards (like
--SEQ) are replaced with concrete domain-specific variable names (likeAESEQ) across the codebase, especially in rule processing and operation parameter handling. It also adds support for thejust_dateparameter in uniqueness checks, refines test coverage, and updates schema and documentation for new functionality.Domain wildcard replacement and parameter preprocessing
_preprocess_operation_paramsmethod toRuleProcessorthat performs shallow copying and recursive wildcard replacement for operation parameters, ensuring domain-specific variable names are used without mutating the original input objects. This method also handles supplemental domains by switching tordomainwhen appropriate. (cdisc_rules_engine/utilities/rule_processor.py)_preprocess_operation_paramsbefore executing operations, ensuring all parameters are correctly formatted for the current domain. (cdisc_rules_engine/utilities/rule_processor.py)tests/unit/test_utilities/test_rule_processor.py)Uniqueness check enhancements
is_unique_setoperator to support a newjust_dateparameter, which allows uniqueness checks to be performed on just the date portion of datetime values, ignoring time. (cdisc_rules_engine/check_operators/dataframe_operators.py)just_dateparameter, clarifying its usage for users. (resources/schema/Operator.json,resources/schema/Operator.md) [1] [2]Minor fixes and test improvements
variable_is_nulloperation to avoid unnecessary domain prefix replacement, simplifying the logic. (cdisc_rules_engine/operations/variable_is_null.py,tests/unit/test_operations/test_variable_is_null.py) [1] [2]cdisc_rules_engine/operations/record_count.py)tests/unit/test_utilities/test_rule_processor.py) [1] [2] [3] [4]These changes collectively improve the accuracy, maintainability, and usability of rule processing and dataset operations in the codebase.