-
Notifications
You must be signed in to change notification settings - Fork 27
720: Ignore not existing domains in the operations #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I was testing this branch using SEND105. I changed the rule to this
The editor put out this result:
I used the excel datset from the zip in connected issue. @gerrycampion is this output what you would intend the engine to give? |
@RamilCDISC , Yes I would expect this result. You are trying to do a column operator, |
| f"Operation {operation_params.operation_name} requires Domain " | ||
| f"{operation_params.domain} but Domain not found in dataset" | ||
| logger.info( | ||
| f"Domain {operation_params.domain} doesn't exist in the dataset" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" in the dataset" doesn't make sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we used the json output format and compared those results instead of the excel results. Using excel is a bit harder to visualize and seems like it could break easily with minor updates to the excel template.
No description provided.