Skip to content

Conversation

@alexfurmenkov
Copy link
Collaborator

No description provided.

@alexfurmenkov alexfurmenkov linked an issue Nov 4, 2025 that may be closed by this pull request
@alexfurmenkov alexfurmenkov marked this pull request as ready for review November 6, 2025 13:54
@RamilCDISC
Copy link
Collaborator

I was testing this branch using SEND105. I changed the rule to this

Check:

any:

- all:
    - name: TX
      operator: non_empty
    - name: $distinct_txparmcd
      operator: does_not_contain
      value: SPECIES
      value_is_literal: true

Core:
Id: CDISC.SENDIG.105
Status: Draft
Version: '1'
Description: Raise an error when the variable SPECIES is not present in DM, and
there is no record TSPARMCD=SPECIES in TS and there is no record
TXPARMCD=SPECIES in TX
Executability: Fully Executable
Operations:

  • domain: TS
    id: $distinct_tsparmcd
    name: TSPARMCD
    operator: distinct
  • domain: TX
    id: $distinct_txparmcd
    name: TXPARMCD
    operator: distinct

The editor put out this result:

{
"DM": [
{
"executionStatus": "execution_error",
"dataset": "dm.xpt",
"domain": "DM",
"variables": [],
"message": "rule execution error",
"errors": [
{
"dataset": "dm.xpt",
"error": "Column not found in data",
"message": "TX"
}
]
}
],
"TS": [
{
"executionStatus": "execution_error",
"dataset": "ts.xpt",
"domain": "TS",
"variables": [],
"message": "rule execution error",
"errors": [
{
"dataset": "ts.xpt",
"error": "Column not found in data",
"message": "TX"
}
]
}
]
}

I used the excel datset from the zip in connected issue. @gerrycampion is this output what you would intend the engine to give?

@gerrycampion
Copy link
Collaborator

TX

@RamilCDISC , Yes I would expect this result. You are trying to do a column operator, non_empty on a dataset TX instead of a column. Because the TX column does not exist, you get this error.

f"Operation {operation_params.operation_name} requires Domain "
f"{operation_params.domain} but Domain not found in dataset"
logger.info(
f"Domain {operation_params.domain} doesn't exist in the dataset"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" in the dataset" doesn't make sense to me

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we used the json output format and compared those results instead of the excel results. Using excel is a bit harder to visualize and seems like it could break easily with minor updates to the excel template.

SFJohnson24 and others added 3 commits November 13, 2025 16:32
* attribute incorrectly named

* tests, operator working

* docs

---------

Co-authored-by: RamilCDISC <113539111+RamilCDISC@users.noreply.github.com>
* version

* fix
@alexfurmenkov alexfurmenkov deleted the 720-ignore-not-existing-domains branch November 13, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule blocked: SEND105

6 participants