Skip to content

Conversation

@SFJohnson24
Copy link
Collaborator

@SFJohnson24 SFJohnson24 commented Oct 30, 2025

image this PR updates the cache (updates several rules that were cached as tig/1-0 without a substandard). It updates the schema for tig--see above screen shot which tells users if they put TIG, a substandard is needed It also updates how the list-set-rules is done to list the substandard as part of the tuple set key.

@SFJohnson24 SFJohnson24 marked this pull request as ready for review October 30, 2025 19:58
@SFJohnson24 SFJohnson24 self-assigned this Oct 30, 2025
rules_directory[sub_key].append(core_id)

else:
key = f"{std_name}/{std_version}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain why are we repeating this here? The block

key = f"{std_name}/{std_version}"
 if (
     key in rules_directory
     and core_id not in rules_directory[key]
):
      rules_directory[key].append(core_id)

is same as on line 159 - 164

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is artifact--removed it

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the list-rule-set and cache for TIG to correctly represent TIG standards.
The PR was validated by:

  1. Reviewing the PR for any unwanted code or comments.
  2. Reviewing the updated logic in accordance with the AC.
  3. Ensuring all unit and regression testing pass.
  4. Running manual validation using TIG standard on cli.
  5. Ensuring the updated schema works as intended.

@RamilCDISC RamilCDISC merged commit 2d9154b into main Nov 4, 2025
11 checks passed
@RamilCDISC RamilCDISC deleted the list-rule-set branch November 4, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants