trailing zeroes #1414
Merged
trailing zeroes #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
approved these changes
Nov 3, 2025
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds functionality to remove trialing zeros to custom_str_conversion. The PR was validated by:
-
Reviewing the PR for unwanted code or comments.
-
Reviewing the updated logic in accordance with AC.
-
Validating all unit and regression testing pass.
-
Validating all related testing and documentation is updated.
-
Running manual validations using dev editor with positive datasets.
-
Running manual validations with negative datasets.
-
Covering edge cases where:
- Both values are null
- One value is string and other is int
- Comparison between values such as 149.85 and 150 without rounding.
- One value is non number string and other is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR modifies the custom_str_conversion called by type_insensitive to remove trailing 0's from both str and float types.
here are the jsons for FB3102, positive 2 (with updated rule)
Datasets.json
Rule_underscores.json
CORE-Report-2025-10-30T13-27-21.xlsx
this positive data now correctly returns 0 issues instead of the two it did before when comparing 200.00 and 200 as well as -44 and -44.0.