Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates the is_contained_by
to test CG0001:
negative1 should have 2 issues but shows 3. CM dataset has C49563 in both define_variable_codelist_coded_codes and domain_lib_ccode so it should not flag this as an issues as it is_not_contained_by. The issue stems from it not parsing the values from the target. it is looking for the list ['C49563 '] instead of looking for the value within the other list.
This pull request updates the logic for checking containment within the
is_contained_bymethod indataframe_operators.py. The main improvement is more robust handling of columns containing iterable values, ensuring that containment checks work correctly for lists and other iterables in DataFrame columns.Containment logic improvements:
is_contained_bymethod to iterate over columns of iterables, using the newis_infunction to check if any item in a list is contained in the comparator value, ensuring correct handling of columns with lists.is_infunction, which is now used for containment checks.