1387 improve error #1407
Merged
1387 improve error #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
requested changes
Oct 28, 2025
gerrycampion
requested changes
Oct 28, 2025
Collaborator
|
The ticket is clear from my side. Once @gerrycampion complete his review with the changes made on his request. I will put my closing comment and merge. |
gerrycampion
requested changes
Nov 4, 2025
Collaborator
gerrycampion
left a comment
gerrycampion
left a comment
There was a problem hiding this comment.
minor issues, otherwise looks good
gerrycampion
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1387: Replace KeyError crash with user-friendly error messages for unsupported dataset formats
When users pointed the -d flag to folders containing unsupported file formats (like XLSX), CORE crashed with an unhelpful KeyError: 'XLSX' traceback. This fix adds early validation in core.py and list_dataset_metadata_handler.py to catch unsupported formats before they reach the service layer, displaying clear error messages like "No valid dataset files found. Supported formats: SAS V5 XPT or Dataset-JSON (JSON or NDJSON). Please ensure your directory contains files in one of these formats." The solution includes comprehensive regression tests, updated README documentation, and uses consistent constants across all files while maintaining backward compatibility for valid dataset files.