1372 datetime comparison #1406
Merged
1372 datetime comparison #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilCDISC
reviewed
Nov 3, 2025
…rison' into 1372-Datetime-Comparison
RamilCDISC
requested changes
Nov 3, 2025
…d test cases with 'T' in data list
…ds left over from refactoring
gerrycampion
requested changes
Nov 18, 2025
Collaborator
gerrycampion
left a comment
gerrycampion
left a comment
There was a problem hiding this comment.
I went through and made a bunch of changes because I felt it was easier than writing all the comments. Primarily the changes remove redundant code and take advantage of enums by iterating over the enums wherever possible instead of handling each enum case individually.
Please review the changes I've made to see how this type of repetition could be avoided and let me know if you disagree with any of those changes. I did not modify the test cases, so I think it should produce the same results. I do have one additional comment to be addressed.
gerrycampion
requested changes
Nov 19, 2025
gerrycampion
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automatic precision detection for date comparison operators (Issue #1372 )
Extends the existing date_component parameter to accept "auto" as a value, enabling automatic precision detection when comparing dates with different granularity levels. When specified, the system detects the precision of both dates and compares them at the common (less precise) level. This solves the use case of comparing date-only fields like RFSTDTC ("2025-06-25") with datetime fields like AESTDTC ("2025-06-25T17:22") at the appropriate precision level. Implementation includes support for CDISC partial dates and uncertainty markers, comprehensive test coverage, and updated documentation in README.md and Operator.md.