Rules 2

[SFJohnson24]

No description provided.

[gerrycampion]

This looks awesome. Two more thoughts, would like to get your opinion. I don't know if it's worth the trouble:

• Should we rename the metadata files with an underscore (_variables.csv, _datasets.csv)? This will order them alphabetically before any data files and make it clear that they are metadata.
• Should we continue to use "abc.xpt" in the datasets filename column or just have "abc.csv" as the filename. Not sure how necessary it is to continue "simulating" these as xpt files vs just making csv a normal data source.

[SFJohnson24]

@gerrycampion

• this first change would be fairly simple--we would need to change how all the engine logic works to match it. I dont know if it is needed? I could ask Els/Jozef/Marcelina for their input

• i would think this would require a fair bit of changes in reporting/the metadata object/reader. Would not be hard to change all the files to remove the .xpt but I am curious how much engine overhaul this would require since all our data inputs are meant to mimic xpt

[gerrycampion]

• i would think this would require a fair bit of changes in reporting/the metadata object/reader. Would not be hard to change all the files to remove the .xpt but I am curious how much engine overhaul this would require since all our data inputs are meant to mimic xpt

It would be probably be a lot less overhaul than you might think, especially after my latest refactor, which does away with a lot of the filename dependency cdisc-org/cdisc-rules-engine#1691

[SFJohnson24]

@gerrycampion
tested and running the datasets and variables with no .xpt extension executes, returns ae.csv as the dataset instead of xpt--changed this to reflect that
also changed the engine PR to reflect these changes