People/sam/cocoascript boxing cleanup

Cocoa Script.xcodeproj/project.pbxproj

@@ -7,6 +7,14 @@
 	objects = {
 
 /* Begin PBXBuildFile section */
+		229C1FF61C21B38D004C5B3B /* MOBoxManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 229C1FF41C21B38D004C5B3B /* MOBoxManager.h */; };
+		229C1FF71C21B38D004C5B3B /* MOBoxManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 229C1FF51C21B38D004C5B3B /* MOBoxManager.m */; };
+		220D93E71C92E69C001EF05C /* JSTTextView.m in Sources */ = {isa = PBXBuildFile; fileRef = CC66D8CD181A2E2F0039A0A5 /* JSTTextView.m */; };
+		229C1FF81C21B38D004C5B3B /* MOBoxManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 229C1FF51C21B38D004C5B3B /* MOBoxManager.m */; };
+		22FBD9951C47EA55004CF31E /* MOBoxManagerBoxContext.h in Headers */ = {isa = PBXBuildFile; fileRef = 22FBD9931C47EA55004CF31E /* MOBoxManagerBoxContext.h */; };
+		220D93E81C92E75A001EF05C /* JSTTextView.h in Headers */ = {isa = PBXBuildFile; fileRef = CC66D8CC181A2E2F0039A0A5 /* JSTTextView.h */; settings = {ATTRIBUTES = (Public, ); }; };
+		22FBD9961C47EA55004CF31E /* MOBoxManagerBoxContext.m in Sources */ = {isa = PBXBuildFile; fileRef = 22FBD9941C47EA55004CF31E /* MOBoxManagerBoxContext.m */; };
+		22FBD9971C47EA55004CF31E /* MOBoxManagerBoxContext.m in Sources */ = {isa = PBXBuildFile; fileRef = 22FBD9941C47EA55004CF31E /* MOBoxManagerBoxContext.m */; };
 		384830E21832D48500B34168 /* COSTarget.h in Headers */ = {isa = PBXBuildFile; fileRef = 384830E01832D48500B34168 /* COSTarget.h */; };
 		384830E31832D48500B34168 /* COSTarget.m in Sources */ = {isa = PBXBuildFile; fileRef = 384830E11832D48500B34168 /* COSTarget.m */; };
 		8D15AC340486D014006FF6A4 /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 1058C7A7FEA54F5311CA2CBB /* Cocoa.framework */; };
@@ -29,7 +37,7 @@
 		CC4143520F25261200E46669 /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = CCC5B8A40F1EFA6D00126722 /* JavaScriptCore.framework */; };
 		CC4143530F25261300E46669 /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 1058C7A7FEA54F5311CA2CBB /* Cocoa.framework */; };
 		CC4143620F2527CD00E46669 /* CocoaScript.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = CC41431A0F25254200E46669 /* CocoaScript.framework */; };
-		CC4143660F2527E400E46669 /* CocoaScript.framework in Copy Frameworks */ = {isa = PBXBuildFile; fileRef = CC41431A0F25254200E46669 /* CocoaScript.framework */; };
+		CC4143660F2527E400E46669 /* CocoaScript.framework in Copy Frameworks */ = {isa = PBXBuildFile; fileRef = CC41431A0F25254200E46669 /* CocoaScript.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, ); }; };
 		CC5EDD4D1237F6DF00E0D965 /* JSTalkStatusIcon.png in Resources */ = {isa = PBXBuildFile; fileRef = CC5EDD4C1237F6DF00E0D965 /* JSTalkStatusIcon.png */; };
 		CC5EDD531237F71300E0D965 /* JSTalkStatusIconAlt.png in Resources */ = {isa = PBXBuildFile; fileRef = CC5EDD521237F71300E0D965 /* JSTalkStatusIconAlt.png */; };
 		CC5FB7DF0F1FDE3800F4ECC2 /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 1058C7A7FEA54F5311CA2CBB /* Cocoa.framework */; };
@@ -397,6 +405,11 @@
 /* Begin PBXFileReference section */
 		1058C7A7FEA54F5311CA2CBB /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = /System/Library/Frameworks/Cocoa.framework; sourceTree = "<absolute>"; };
 		13E42FBA07B3F13500E4EEF1 /* CoreData.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreData.framework; path = /System/Library/Frameworks/CoreData.framework; sourceTree = "<absolute>"; };
+		229C1FF41C21B38D004C5B3B /* MOBoxManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MOBoxManager.h; path = src/framework/mocha/Objects/MOBoxManager.h; sourceTree = SOURCE_ROOT; };
+		229C1FF51C21B38D004C5B3B /* MOBoxManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = MOBoxManager.m; path = src/framework/mocha/Objects/MOBoxManager.m; sourceTree = SOURCE_ROOT; };
+		22E281E41A8BB99D006650D2 /* test.js */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.javascript; path = test.js; sourceTree = "<group>"; };
+		22FBD9931C47EA55004CF31E /* MOBoxManagerBoxContext.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MOBoxManagerBoxContext.h; path = src/framework/mocha/Objects/MOBoxManagerBoxContext.h; sourceTree = SOURCE_ROOT; };
+		22FBD9941C47EA55004CF31E /* MOBoxManagerBoxContext.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = MOBoxManagerBoxContext.m; path = src/framework/mocha/Objects/MOBoxManagerBoxContext.m; sourceTree = SOURCE_ROOT; };
 		2A37F4C4FDCFA73011CA2CEA /* AppKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = AppKit.framework; path = /System/Library/Frameworks/AppKit.framework; sourceTree = "<absolute>"; };
 		2A37F4C5FDCFA73011CA2CEA /* Foundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Foundation.framework; path = /System/Library/Frameworks/Foundation.framework; sourceTree = "<absolute>"; };
 		384830E01832D48500B34168 /* COSTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = COSTarget.h; path = src/framework/COSTarget.h; sourceTree = "<group>"; };
@@ -768,6 +781,7 @@
 			children = (
 				CC66D826181A2A810039A0A5 /* CocoaScript_Prefix.pch */,
 				CC66D8D7181A2FC10039A0A5 /* cocoascript_tool.m */,
+				22E281E41A8BB99D006650D2 /* test.js */,
 			);
 			name = "Other Sources";
 			sourceTree = "<group>";
@@ -1130,6 +1144,10 @@
 				CC66D879181A2B0A0039A0A5 /* MOAllocator.m */,
 				CC66D87A181A2B0A0039A0A5 /* MOBox.h */,
 				CC66D87B181A2B0A0039A0A5 /* MOBox.m */,
+				229C1FF41C21B38D004C5B3B /* MOBoxManager.h */,
+				229C1FF51C21B38D004C5B3B /* MOBoxManager.m */,
+				22FBD9931C47EA55004CF31E /* MOBoxManagerBoxContext.h */,
+				22FBD9941C47EA55004CF31E /* MOBoxManagerBoxContext.m */,
 				CC66D87C181A2B0A0039A0A5 /* MOClassDescription.h */,
 				CC66D87D181A2B0A0039A0A5 /* MOClassDescription.m */,
 				CC66D87E181A2B0A0039A0A5 /* MOClosure_Private.h */,
@@ -1247,6 +1265,7 @@
 				CC66D8B2181A2B0A0039A0A5 /* MOPointer_Private.h in Headers */,
 				CCA1A535183EA86E000159B3 /* COSInterval.h in Headers */,
 				CC66D8BC181A2B0A0039A0A5 /* MOStruct.h in Headers */,
+				220D93E81C92E75A001EF05C /* JSTTextView.h in Headers */,
 				CC66D7D5181A2A470039A0A5 /* TDMultiLineCommentState.h in Headers */,
 				CC66D7BD181A2A470039A0A5 /* TDAssembly.h in Headers */,
 				CCE675E8182ED9C900DB1932 /* COSAlertWindow.h in Headers */,
@@ -1261,6 +1280,7 @@
 				CC66D869181A2AE10039A0A5 /* MochaRuntime_Private.h in Headers */,
 				CC66D8B9181A2B0A0039A0A5 /* MOProtocolDescription_Private.h in Headers */,
 				CC66D824181A2A710039A0A5 /* COSPreprocessor.h in Headers */,
+				22FBD9951C47EA55004CF31E /* MOBoxManagerBoxContext.h in Headers */,
 				CC66D836181A2A9B0039A0A5 /* COSCodeSketcher.h in Headers */,
 				CC66D84E181A2AB10039A0A5 /* MOBridgeSupportSymbol.h in Headers */,
 				CCD38343195A454F00C436B9 /* COSDatabase.h in Headers */,
@@ -1272,6 +1292,7 @@
 				CC66D7CD181A2A470039A0A5 /* TDEmpty.h in Headers */,
 				CC66D8A3181A2B0A0039A0A5 /* MOClosure.h in Headers */,
 				CC66D7CF181A2A470039A0A5 /* TDLetter.h in Headers */,
+				229C1FF61C21B38D004C5B3B /* MOBoxManager.h in Headers */,
 				CC66D7E6181A2A470039A0A5 /* TDRepetition.h in Headers */,
 				CC66D834181A2A9B0039A0A5 /* COSCIImageAdditions.h in Headers */,
 				CC66D83E181A2A9B0039A0A5 /* COSQuickCIFilter.h in Headers */,
@@ -1392,7 +1413,7 @@
 		2A37F4A9FDCFA73011CA2CEA /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 0500;
+				LastUpgradeCheck = 0800;
 				TargetAttributes = {
 					9FC343C61AF7D2FE00B53759 = {
 						CreatedOnToolsVersion = 6.3.1;
@@ -1506,6 +1527,7 @@
 				CC66D7DF181A2A470039A0A5 /* TDParser.m in Sources */,
 				384830E31832D48500B34168 /* COSTarget.m in Sources */,
 				CC66D86B181A2AE10039A0A5 /* MochaRuntime.m in Sources */,
+				229C1FF81C21B38D004C5B3B /* MOBoxManager.m in Sources */,
 				CC66D821181A2A710039A0A5 /* COSExtras.m in Sources */,
 				CC66D83F181A2A9B0039A0A5 /* COSQuickCIFilter.m in Sources */,
 				CC66D81F181A2A710039A0A5 /* COScript.m in Sources */,
@@ -1558,6 +1580,7 @@
 				CC66D813181A2A470039A0A5 /* TDWordOrReservedState.m in Sources */,
 				CC66D7CA181A2A470039A0A5 /* TDCommentState.m in Sources */,
 				CC66D7E9181A2A470039A0A5 /* TDReservedWord.m in Sources */,
+				22FBD9971C47EA55004CF31E /* MOBoxManagerBoxContext.m in Sources */,
 				CC66D7D0181A2A470039A0A5 /* TDLetter.m in Sources */,
 				CC66D75B181A2A210039A0A5 /* TETextUtils.m in Sources */,
 				CC66D84D181A2AB10039A0A5 /* MOBridgeSupportParser.m in Sources */,
@@ -1566,6 +1589,7 @@
 				CC66D7E5181A2A470039A0A5 /* TDReader.m in Sources */,
 				CC66D7D6181A2A470039A0A5 /* TDMultiLineCommentState.m in Sources */,
 				CC66D8B1181A2B0A0039A0A5 /* MOObjCRuntime.m in Sources */,
+				220D93E71C92E69C001EF05C /* JSTTextView.m in Sources */,
 				CC07AF4D1982C310001CCA93 /* COSMarkdown.m in Sources */,
 				CC66D807181A2A470039A0A5 /* TDTokenizerState.m in Sources */,
 				CC66D84F181A2AB10039A0A5 /* MOBridgeSupportSymbol.m in Sources */,
@@ -1647,6 +1671,7 @@
 				CC9FEFE218296A2A009DB0F9 /* TDEmpty.m in Sources */,
 				CC9FEFE418296A2A009DB0F9 /* TDLetter.m in Sources */,
 				CC9FEFE618296A2A009DB0F9 /* TDLiteral.m in Sources */,
+				22FBD9961C47EA55004CF31E /* MOBoxManagerBoxContext.m in Sources */,
 				CC9FEFE818296A2A009DB0F9 /* TDLowercaseWord.m in Sources */,
 				CC9FEFEA18296A2A009DB0F9 /* TDMultiLineCommentState.m in Sources */,
 				CCD38344195A454F00C436B9 /* COSDatabase.m in Sources */,
@@ -1672,6 +1697,7 @@
 				CC9FF01118296A2B009DB0F9 /* TDToken.m in Sources */,
 				CC9FF01318296A2B009DB0F9 /* TDTokenArraySource.m in Sources */,
 				CC9FF01518296A2B009DB0F9 /* TDTokenAssembly.m in Sources */,
+				229C1FF71C21B38D004C5B3B /* MOBoxManager.m in Sources */,
 				CC9FF01718296A2B009DB0F9 /* TDTokenizer.m in Sources */,
 				CCD3834A195A454F00C436B9 /* COSDatabaseQueue.m in Sources */,
 				CC9FF01918296A2B009DB0F9 /* TDTokenizerState.m in Sources */,
@@ -1812,6 +1838,7 @@
 				ONLY_ACTIVE_ARCH = YES;
 				OTHER_CFLAGS = "-DDEBUG";
 				OTHER_LDFLAGS = "-lffi";
+				PRODUCT_BUNDLE_IDENTIFIER = com.cocoascript.CocoaScript;
 				PRODUCT_NAME = "Cocoa Script Editor";
 			};
 			name = Debug;
@@ -1827,6 +1854,7 @@
 				LD_RUNPATH_SEARCH_PATHS = "@executable_path/../Frameworks";
 				ONLY_ACTIVE_ARCH = YES;
 				OTHER_LDFLAGS = "-lffi";
+				PRODUCT_BUNDLE_IDENTIFIER = com.cocoascript.CocoaScript;
 				PRODUCT_NAME = "Cocoa Script Editor";
 			};
 			name = Release;
@@ -1840,9 +1868,13 @@
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
+				ENABLE_STRICT_OBJC_MSGSEND = YES;
+				ENABLE_TESTABILITY = YES;
 				GCC_C_LANGUAGE_STANDARD = c99;
+				GCC_NO_COMMON_BLOCKS = YES;
 				GCC_OPTIMIZATION_LEVEL = 0;
 				GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
 				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
@@ -1866,9 +1898,12 @@
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
+				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				GCC_C_LANGUAGE_STANDARD = c99;
+				GCC_NO_COMMON_BLOCKS = YES;
 				GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
 				GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
@@ -1912,7 +1947,9 @@
 					AppKit,
 					"-lexpat",
 				);
+				PRODUCT_BUNDLE_IDENTIFIER = "com.cocoascript.${PRODUCT_NAME:identifier}";
 				PRODUCT_NAME = CocoaScript;
+				SKIP_INSTALL = YES;
 			};
 			name = Debug;
 		};
@@ -1924,6 +1961,7 @@
 				COPY_PHASE_STRIP = YES;
 				DYLIB_COMPATIBILITY_VERSION = 1;
 				DYLIB_CURRENT_VERSION = 1;
+				ENABLE_NS_ASSERTIONS = NO;
 				FRAMEWORK_VERSION = A;
 				GCC_PRECOMPILE_PREFIX_HEADER = YES;
 				GCC_PREFIX_HEADER = src/framework/CocoaScript_Prefix.pch;
@@ -1945,7 +1983,9 @@
 					"-lexpat",
 					"-lffi",
 				);
+				PRODUCT_BUNDLE_IDENTIFIER = "com.cocoascript.${PRODUCT_NAME:identifier}";
 				PRODUCT_NAME = CocoaScript;
+				SKIP_INSTALL = YES;
 			};
 			name = Release;
 		};
@@ -2002,6 +2042,7 @@
 				9FC343D21AF7D2FE00B53759 /* Release */,
 			);
 			defaultConfigurationIsVisible = 0;
+			defaultConfigurationName = Release;
 		};
 		C05733C708A9546B00998B17 /* Build configuration list for PBXNativeTarget "Cocoa Script Editor" */ = {
 			isa = XCConfigurationList;

res/Info.plist

@@ -51,25 +51,12 @@
 			<string>JSTPluginMover</string>
 		</dict>
 	</array>
-
-	<key>CFBundleURLTypes</key>
-	<array>
-		<dict>
-			<key>CFBundleURLName</key>
-			<string>Cocoa Script Whatever</string>
-			<key>CFBundleURLSchemes</key>
-			<array>
-				<string>x-coscript</string>
-			</array>
-		</dict>
-	</array>
-
 	<key>CFBundleExecutable</key>
 	<string>Cocoa Script Editor</string>
 	<key>CFBundleIconFile</key>
 	<string>JSTalk.icns</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.cocoascript.CocoaScript</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleName</key>
@@ -80,6 +67,17 @@
 	<string>3</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
+	<key>CFBundleURLTypes</key>
+	<array>
+		<dict>
+			<key>CFBundleURLName</key>
+			<string>Cocoa Script Whatever</string>
+			<key>CFBundleURLSchemes</key>
+			<array>
+				<string>x-coscript</string>
+			</array>
+		</dict>
+	</array>
 	<key>CFBundleVersion</key>
 	<string>1</string>
 	<key>LSApplicationCategoryType</key>

res/JSTalkFramework-Info.plist

@@ -7,7 +7,7 @@
 	<key>CFBundleExecutable</key>
 	<string>${EXECUTABLE_NAME}</string>
 	<key>CFBundleIdentifier</key>
-	<string>com.cocoascript.${PRODUCT_NAME:identifier}</string>
+	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundlePackageType</key>

src/cocoascript_tool.m

@@ -4,6 +4,19 @@
 
 BOOL JSCErrorHandlerExitOnError = YES;
 
+@interface NullDebugController : NSObject<CODebugController>
+
+@end
+
+@implementation NullDebugController
+
+- (void)output:(NSString*)format args:(va_list)args
+{
+
+}
+
+@end
+
 @interface JSCErrorHandler : NSObject {
 
 }
@@ -92,11 +105,15 @@ int main(int argc, char *argv[]) {
         }
     }
 
+    [COScript setDebugController:[NullDebugController new]];
+
     id o = [t executeString:source];
 
     if (o) {
         printf("%s\n", [[o description] UTF8String]);
     }
 
+    [t cleanup];
+
     return 0;
 }

src/editor/JSTTextView.m

@@ -23,6 +23,7 @@ @interface JSTTextView ()
 @property (assign) CGPoint initialDragPoint;
 @property (strong) NSNumber *initialNumber;
 @property (strong) NSMutableDictionary *numberRanges;
+@property (assign) BOOL parsingInResponseToEdit;
 
 @end
 
@@ -168,9 +169,17 @@ - (void)parseCode:(id)sender {
 }
 
 
-
-- (void) textStorageDidProcessEditing:(NSNotification *)note {
-    [self parseCode:nil];
+- (void)textStorage:(NSTextStorage *)textStorage didProcessEditing:(NSTextStorageEditActions)editedMask range:(NSRange)editedRange changeInLength:(NSInteger)delta {
+    // SD: calling parseCode directly from here was causing the selection to be messed up when deleting characters - seemingly some sort of timing issue.
+    //     deferring the parse has fixed that, but at the expense of causing potential recursion since the parse then seems to register as another edit.
+    //     to avoid this, I've added the parsingInResponseToEdit flag, but it's all a bit clumsy; a better fix might be to sort out the original deletion problem
+    if (!self.parsingInResponseToEdit) {
+        dispatch_async(dispatch_get_main_queue(), ^{
+            self.parsingInResponseToEdit = YES;
+            [self parseCode:nil];
+            self.parsingInResponseToEdit = NO;
+        });
+    }
 }
 
 - (NSArray *)writablePasteboardTypes {
@@ -188,22 +197,22 @@ - (void)autoInsertText:(NSString*)text {
 
 }
 
-- (void)insertText:(id)insertString {
-    
+- (void)insertText:(id)insertString replacementRange:(NSRange)replacementRange {
+
     if (!([JSTPrefs boolForKey:@"codeCompletionEnabled"])) {
-        [super insertText:insertString];
+        [super insertText:insertString replacementRange:replacementRange];
         return;
     }
 
     // make sure we're not doing anything fance in a quoted string.
-    if (NSMaxRange([self selectedRange]) < [[self textStorage] length] && [[[self textStorage] attributesAtIndex:[self selectedRange].location effectiveRange:nil] objectForKey:JSTQuotedStringAttributeName]) {
-        [super insertText:insertString];
+    if (NSMaxRange(replacementRange) < [[self textStorage] length] && [[[self textStorage] attributesAtIndex:replacementRange.location effectiveRange:nil] objectForKey:JSTQuotedStringAttributeName]) {
+        [super insertText:insertString replacementRange:replacementRange];
         return;
     }
 
     if ([@")" isEqualToString:insertString] && [_lastAutoInsert isEqualToString:@")"]) {
 
-        NSRange nextRange   = [self selectedRange];
+        NSRange nextRange   = replacementRange;
         nextRange.length = 1;
 
         if (NSMaxRange(nextRange) <= [[self textStorage] length]) {
@@ -222,8 +231,8 @@ - (void)insertText:(id)insertString {
 
     [self setLastAutoInsert:nil];
 
-    [super insertText:insertString];
-    
+    [super insertText:insertString replacementRange:replacementRange];
+
     NSRange currentRange = [self selectedRange];
     NSRange r = [self selectionRangeForProposedRange:currentRange granularity:NSSelectByParagraph];
     BOOL atEndOfLine = (NSMaxRange(r) - 1 == NSMaxRange(currentRange));

src/framework/COSExtras.m

@@ -102,12 +102,16 @@ - (void)system:(NSString*)s {
 
 @implementation NSApplication (COSExtras)
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+
 - (id)open:(NSString*)pathToFile {
 
     NSError *err = nil;
 
     NSURL *url = [NSURL fileURLWithPath:pathToFile];
 
+    // TODO - this call needs replacing as it is deprecated, but the new API is async so it requires a little bit of work
     id doc = [[NSDocumentController sharedDocumentController] openDocumentWithContentsOfURL:url
                                                                                     display:YES
                                                                                       error:&err];
@@ -120,6 +124,8 @@ - (id)open:(NSString*)pathToFile {
     return doc;
 }
 
+#pragma clang diagnostic pop
+
 - (void)activate {
     ProcessSerialNumber xpsn = { 0, kCurrentProcess };
     SetFrontProcess( &xpsn );