Format, fix, document, Etc 06/15 #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where the unit test for `Init` in `ll::request` would fail for certain abi versions (e.g., `abi-7-36`).
Fixed a bug where the documentation was missing from the `NO_XATTR` constant on a non-linux OS. Using a macro to prevent duplication.
Clippy says it's better to write long constants with underscore separators: [https://rust-lang.github.io/rust-clippy/rust-1.51.0/index.html#unreadable_literal]
Promoted some important items to `public(crate)` for easier testing and future reorganization.
Fixed a bug where the passthrough test would fail on macOS simply because the target file doesn't exist. It can still fail, but the test failure should be related to the feature being tested (i.e., passthrough).
It's safer to define the block size as u32 (its true native type) and cast up to u64 as needed for file attr.
These `check_*` helper functions don't borrow anything from self, so they are better expressed as associated functions.
This `write_directory_content` function copies but doesn't move the entry data, so it is better as a borrowed parameter.
This was referenced Sep 15, 2025
cberner
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR in sequence was #399
Next PR in sequence was #401